feat(onboarding)- add pre onboarding requirements block#1064
Merged
Conversation
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report
|
| Metric | Current | Previous | Change | Status |
|---|---|---|---|---|
| Lines | 89.97% | 90.10% | -0.13% | 🔴 |
| Statements | 89.63% | 89.75% | -0.12% | 🔴 |
| Functions | 87.15% | 87.71% | -0.55% | 🔴 |
| Branches | 80.26% | 80.29% | -0.02% | 🔴 |
Detailed Breakdown
Lines Coverage
- Covered: 3802 / 4226
- Coverage: 89.97%
- Change: -0.13% (72 lines)
Statements Coverage
- Covered: 3864 / 4311
- Coverage: 89.63%
- Change: -0.12% (74 statements)
Functions Coverage
- Covered: 1031 / 1183
- Coverage: 87.15%
- Change: -0.55% (18 functions)
Branches Coverage
- Covered: 2371 / 2954
- Coverage: 80.26%
- Change: -0.02% (33 branches)
✅ Coverage check passed
jordividaller
approved these changes
Jun 3, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 234f5d6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds preonboarding requirements section to the Onboarding
Worked with the BE to integrate the new endpoints, mostly the code works as a standalone component that partners can render on their app on the review step
The whole thing works similarly to what we have in our platform, to test this I recommend checking how it works in the sandbox env in employ and then at moment works
in the sandbox envalso in partners nowI'll spend a bit of time to see if I can set it up on partners env
https://www.loom.com/share/f2aaa453c53d4fdf939698c8070eb798?focus_title=1&muted=1&from_recorder=1
Note
Medium Risk
Changes when employers can invite employees and adds legally meaningful in-platform document signing; behavior is covered by tests but mistakes could block invites or allow premature invites.
Overview
Adds a pre-onboarding document requirements flow to employee onboarding: partners get a new
PreOnboardingRequirementsrender-prop component (wired intoOnboardingFlow) backed by React Query hooks to list requirements, create documents, preview PDFs, and sign in-platform.Invite is blocked until every requirement is
finished(or there are none), including while requirements are still loading, so incomplete signing cannot race ahead of invite.The example review step implements the full UX—constraint acknowledgements, dependency blocking, full-screen PDF preview, and typed-name signature—and exports
PreOnboardingRequirementsBagplusFullScreenDialog/BasicTooltipfrom internals.The OpenAPI client is regenerated with additional employee endpoints (personal details, federal taxes, document upload) and minor payslip scope doc updates; tests, MSW handlers, and fixtures cover the new onboarding APIs.
Reviewed by Cursor Bugbot for commit 234f5d6. Bugbot is set up for automated code reviews on this repo. Configure here.