Skip to content

feat(onboarding)- add pre onboarding requirements block#1064

Merged
gabrielseco merged 46 commits into
mainfrom
pre-onboarding-requirements
Jun 3, 2026
Merged

feat(onboarding)- add pre onboarding requirements block#1064
gabrielseco merged 46 commits into
mainfrom
pre-onboarding-requirements

Conversation

@gabrielseco
Copy link
Copy Markdown
Collaborator

@gabrielseco gabrielseco commented May 27, 2026

Adds preonboarding requirements section to the Onboarding

Worked with the BE to integrate the new endpoints, mostly the code works as a standalone component that partners can render on their app on the review step

The whole thing works similarly to what we have in our platform, to test this I recommend checking how it works in the sandbox env in employ and then at moment works in the sandbox env also in partners now

I'll spend a bit of time to see if I can set it up on partners env

https://www.loom.com/share/f2aaa453c53d4fdf939698c8070eb798?focus_title=1&muted=1&from_recorder=1


Note

Medium Risk
Changes when employers can invite employees and adds legally meaningful in-platform document signing; behavior is covered by tests but mistakes could block invites or allow premature invites.

Overview
Adds a pre-onboarding document requirements flow to employee onboarding: partners get a new PreOnboardingRequirements render-prop component (wired into OnboardingFlow) backed by React Query hooks to list requirements, create documents, preview PDFs, and sign in-platform.

Invite is blocked until every requirement is finished (or there are none), including while requirements are still loading, so incomplete signing cannot race ahead of invite.

The example review step implements the full UX—constraint acknowledgements, dependency blocking, full-screen PDF preview, and typed-name signature—and exports PreOnboardingRequirementsBag plus FullScreenDialog / BasicTooltip from internals.

The OpenAPI client is regenerated with additional employee endpoints (personal details, federal taxes, document upload) and minor payslip scope doc updates; tests, MSW handlers, and fixtures cover the new onboarding APIs.

Reviewed by Cursor Bugbot for commit 234f5d6. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/tests/handlers.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-98ds7o5y5-remotecom.vercel.app
Latest Commit:234f5d6

Deployed with vercel-action

Comment thread src/flows/Onboarding/hooks.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

📊 Coverage Report

⚠️ Coverage decreased

Metric Current Previous Change Status
Lines 89.97% 90.10% -0.13% 🔴
Statements 89.63% 89.75% -0.12% 🔴
Functions 87.15% 87.71% -0.55% 🔴
Branches 80.26% 80.29% -0.02% 🔴

Detailed Breakdown

Lines Coverage
  • Covered: 3802 / 4226
  • Coverage: 89.97%
  • Change: -0.13% (72 lines)
Statements Coverage
  • Covered: 3864 / 4311
  • Coverage: 89.63%
  • Change: -0.12% (74 statements)
Functions Coverage
  • Covered: 1031 / 1183
  • Coverage: 87.15%
  • Change: -0.55% (18 functions)
Branches Coverage
  • Covered: 2371 / 2954
  • Coverage: 80.26%
  • Change: -0.02% (33 branches)

✅ Coverage check passed

Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Comment thread example/src/ReviewOnboardingStep.tsx Outdated
@gabrielseco gabrielseco self-assigned this May 28, 2026
@gabrielseco gabrielseco changed the title Pre onboarding requirements feat(onboarding)- add pre onboarding requirements block May 28, 2026
@gabrielseco gabrielseco requested a review from jordividaller May 28, 2026 15:36
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Comment thread example/src/ReviewOnboardingStep.tsx
Comment thread example/src/ReviewOnboardingStep.tsx Outdated
Comment thread example/src/ReviewOnboardingStep.tsx
Comment thread src/flows/Onboarding/api.ts
Comment thread src/flows/Onboarding/api.ts
Comment thread src/tests/handlers.ts
Comment thread example/src/ReviewOnboardingStep.tsx
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 234f5d6. Configure here.

Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
@gabrielseco gabrielseco merged commit 6590fd7 into main Jun 3, 2026
10 checks passed
@gabrielseco gabrielseco deleted the pre-onboarding-requirements branch June 3, 2026 17:59
@gabrielseco gabrielseco mentioned this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants