Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate
runner_verandshutdown_timeoutbefore either value is embedded in the generated GCE startup script.Changes
runner_veronly aslatestor an exactX.Y.Zversion.shutdown_timeoutonly as an integer from0through86400seconds.latestbefore constructing the startup script.Verification
tests/runner_input_validation_test.shupstream/mainand passes with this change.pre-commit run --all-filesgit diff --checkCompatibility and risk
Documented defaults remain valid. Explicit runner versions must use the existing release format (
X.Y.Z), and shutdown grace periods are capped at 24 hours so they cannot become unbounded startup-script data.Fixes #73