Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request consolidates AWS PrivateLink documentation by extracting common VPC setup procedures into a reusable shared partial file ( Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@modules/networking/partials/private-links-aws-client-vpc-setup.adoc`:
- Around line 98-104: The example for creating a subnet uses an AZ ID value
("usw2-az1") with the --availability-zone parameter which expects an AZ name
(e.g., "us-west-2a"); update the snippet around the aws ec2 create-subnet
example so the AZ format and flag match: either replace the example AZ value
with an AZ name (us-west-2a) when using --availability-zone, or change the flag
to --availability-zone-id when keeping the AZ ID example (usw2-az1); ensure the
surrounding text clarifies which format is required and keep references to
REGION, PROFILE, CLIENT_VPC_ID and the resulting subnet_id/create-subnet command
consistent.
modules/networking/partials/private-links-aws-client-vpc-setup.adoc
Outdated
Show resolved
Hide resolved
…eLink UI doc The dedicated-cluster AWS PrivateLink Cloud UI doc was missing the entire client-side VPC and security group setup section, including the critical per-broker port ranges (32000-32500 for Kafka API, 35000-35500 for HTTP Proxy). - Create shared partial for VPC setup steps used by both UI and API docs - Add "Configure PrivateLink connection" section to the dedicated UI doc - Replace inline VPC setup in the API doc with the shared partial Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6166b0f to
f733bb1
Compare
…zone flag The create-subnet examples showed an AZ ID (usw2-az1) but used the --availability-zone flag, which expects an AZ name (us-west-2a). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Address review feedback: remove redundant partial intro, add transition sentence in UI page, fix heading consistency, rename partial section to "Set up the client VPC", update anchor references, standardize on "Redpanda Cloud Console" and "client VPC" terminology, add (350000 ms) to TIP admonitions, promote CIDR warning to CAUTION, integrate port range NOTE into prose, differentiate broker port comments in serverless files, fix missing ^ on external link, and fix AZ example format. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonlord
left a comment
There was a problem hiding this comment.
Refactor looks good to me.
| --availability-zone <zone> \ | ||
| --cidr-block 10.0.1.0/24 | ||
| SUBNET_ID=<subnet_id> | ||
| ---- |
There was a problem hiding this comment.
"You can also use an existing subnet from your existing VPC"
| === Create VPC subnet | ||
|
|
||
| You need the subnet ID `subnet_id` from the command output to <<create-vpc-endpoint,create a VPC endpoint>>. Run the following command, specifying the subnet availability zone (for example, `usw2-az1`): | ||
| You need the subnet ID `subnet_id` from the command output to <<create-vpc-endpoint,create a VPC endpoint>>. Run the following command, specifying the subnet Availability Zone name (for example, `us-west-2a`): |
The BYOC/Dedicated AWS PrivateLink Cloud UI doc was missing the entire client-side VPC and security group setup section, including the critical per-broker port ranges (32000-32500 for Kafka API, 35000-35500 for HTTP Proxy).
Description
Resolves https://redpandadata.atlassian.net/browse/DOC-1871
Review deadline:
Page previews
Configure AWS PrivateLink in the Cloud Console
Configure AWS PrivateLink with the Cloud API
Checks