#5921 Add geodata Workbench plugin#5922
Draft
pierrelambert wants to merge 12 commits into
Draft
Conversation
Centralize geodata map colors, remove demo visualization ids, and document the tile-provider policy for PR review. References: redis#5921
Update geodata Workbench E2E expectations and test-plan names for the default OSM tile configuration. References: redis#5921
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Author
|
Maintainer note: this PR needs the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5921
What
Adds a bundled internal Workbench geodata plugin.
The plugin supports native Redis GEO commands with map, heatmap, and inspector views, and adds opt-in Redis Query Engine geodata visualizations for
FT.SEARCH,FT.AGGREGATE, andFT.HYBRIDwhen GEO or GEOSHAPE predicates are detected.Key decisions:
public/config.json; fallback renders unavailable state.Dependencies / Policy Note
New runtime dependencies:
leafletleaflet.heatleaflet.markerclusterLeaflet is used because it gives us proven map rendering, pan/zoom behavior, tile support, heatmaps, and marker clustering without building fragile custom map primitives. Leaflet is open-source, but maintainers should confirm both the dependency choice and the default external tile-provider policy before this ships.
Evidence
Manual validation was done with RedisInsight against Redis 8.6.2.
Dense native GEO heatmap, showing multiple clusters and density changes while zooming:
Native GEO clustered map:
Native GEO map:
RQE
FT.SEARCHGEO map:RQE
FT.SEARCHGEOSHAPE map with OSM basemap:Missing returned geo field guidance:
Plain
FT.SEARCH idx "*"keeps the default non-geodata result view:Testing
/opt/homebrew/bin/rtk npx yarn@1.22.22 lint/opt/homebrew/bin/rtk npx yarn@1.22.22 test:cov --ci --silent/opt/homebrew/bin/rtk npx yarn@1.22.22 --cwd redisinsight/api test:cov --ci --silent/opt/homebrew/bin/rtk npx yarn@1.22.22 --cwd redisinsight/ui/src/packages/geodata test --coverage --coverageReporters=text/opt/homebrew/bin/rtk npx yarn@1.22.22 --cwd redisinsight/ui/src/packages/geodata typecheck/opt/homebrew/bin/rtk npx yarn@1.22.22 build:staticsOSS_STANDALONE_PORT=6379 /opt/homebrew/bin/rtk npm run test:chromium -- tests/main/workbench/geodata-plugin.spec.tsNotes
Repo-wide
yarn type-check:uistill fails in unrelated baseline files outside this geodata/plugin change. The changed geodata package typecheck passes.