Repository navigation
Hide java.dashboard.refresh and java.dashboard.dumpState from Command… - #4538
Open
sripal2013 wants to merge 1 commit into
Open
sripal2013 wants to merge 1 commit into
sripal2013 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4381
Running Java: Refresh (or Java: Dump State) from the Command Palette fails with
command 'java.dashboard.refresh' not foundwhen the Java Dashboard has never been opened. The command handlers are registered inside the dashboard webview class, so they only exist while the panel is alive. Thewhenclause oncontributes.commandsdoes not control Command Palette visibility —contributes.menus.commandPalettedoes — and these two commands were never added there.This adds both commands to
contributes.menus.commandPalettewith"when": "false", matching the 11 existing entries that already use this pattern for internal-only commands. The dashboard's own title-bar buttons (gated onwebviewId == java.dashboard) keep working.Test: fresh Extension Development Host window → Command Palette → "Java: Refresh" no longer appears (previously appeared and threw). Opened the Java Dashboard and confirmed its Refresh / Dump State toolbar buttons still work.
Note: #4382 attempted a different fix (register at activation and open the dashboard on invoke) but is stale and conflicted; this takes the minimal approach suggested in the issue thread.