Conversation
… for when orchestrator-1.9 needs an update); also do the prior version release step if needs.check-merged-pr.outputs.needs_release is true Signed-off-by: Nick Boldt <nboldt@redhat.com>
nickboldt
changed the title
Review Summary by QodoSupport manual workflow dispatch for workspace version releases
WalkthroughsDescription• Add manual workflow dispatch trigger with workspace, branch, and force_release inputs • Skip release check when force_release is true to allow manual overrides • Trigger release job when force_release is enabled or needs_release is true • Enable manual control over workspace version releases independent of PR events Diagramflowchart LR
A["workflow_dispatch inputs<br/>workspace, branch, force_release"] -->|"manual trigger"| B["release_workspace_version workflow"]
C["pull_request closed event"] -->|"automatic trigger"| B
B -->|"force_release=true"| D["Skip release check"]
B -->|"force_release=false"| E["Run release check"]
D -->|"proceed"| F["Update Version Packages PR"]
E -->|"needs_release=true"| F
F -->|"version PR created"| G["Release job"]
D -->|"or force_release=true"| G
File Changes1. .github/workflows/release_workspace_version.yml
|
Code Review by Qodo
1. Manual dispatch will fail
|
|
![rhdh-qodo-merge[bot]](https://avatars.githubusercontent.com/in/1961108?s=60&v=4){kind=small}
Comment on lines
+4
to
+18
| workflow_dispatch: | ||
| inputs: | ||
| workspace: | ||
| description: 'Name of the Workspace' | ||
| required: true | ||
| type: string | ||
| force_release: | ||
| description: 'Force release even if no changesets are present' | ||
| required: false | ||
| type: boolean | ||
| branch: | ||
| description: 'Branch to run the workflow on' | ||
| required: true | ||
| default: '' | ||
| type: string |
There was a problem hiding this comment.
1. Manual dispatch will fail 🐞 Bug ⛯ Reliability
workflow_dispatch was added, but the workflow’s first job still unconditionally reads github.event.pull_request.*, which does not exist for manual runs. As a result, manually triggering the workflow will fail or compute empty outputs, and the new workspace/branch inputs are not wired into the job logic.
Agent Prompt
## Issue description
Manual `workflow_dispatch` runs will fail because the workflow assumes a `pull_request` event payload (`github.event.pull_request.*`) even when triggered manually. The newly added `workspace`/`branch` inputs are not integrated into the job logic.
## Issue Context
This workflow is now triggered by both `pull_request: closed` and `workflow_dispatch`. For `workflow_dispatch`, there is no `pull_request` object in the event payload.
## Fix Focus Areas
- .github/workflows/release_workspace_version.yml[3-66]
- .github/workflows/release_workspace_version.yml[67-90]
- .github/workflows/release_workspace_version.yml[150-167]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| runs-on: ubuntu-latest | ||
| needs: check-merged-pr | ||
| if: needs.check-merged-pr.outputs.is_version_pr == 'true' | ||
| if: needs.check-merged-pr.outputs.is_version_pr == 'true' || needs.check-merged-pr.outputs.needs_release == 'true' || inputs.force_release == true |
There was a problem hiding this comment.
2. Release checks wrong output 🐞 Bug ✓ Correctness
The release job condition references needs.check-merged-pr.outputs.needs_release, but check-merged-pr does not output needs_release. This makes the new “run release when needs_release is true” behavior non-functional.
Agent Prompt
## Issue description
The `release` job checks `needs.check-merged-pr.outputs.needs_release`, but that output does not exist on `check-merged-pr`. As a result, the new release gating will never trigger based on `needs_release`.
## Issue Context
`needs_release` is currently exported by the `changesets-pr` job, not `check-merged-pr`. The `release` job must either depend on `changesets-pr` or compute/export `needs_release` elsewhere.
## Fix Focus Areas
- .github/workflows/release_workspace_version.yml[67-80]
- .github/workflows/release_workspace_version.yml[150-156]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| - name: Update Version Packages (${{ needs.check-merged-pr.outputs.workspace_name }}) PR | ||
| id: changesets-pr | ||
| if: steps.release_check.outputs.needs_release != 'true' | ||
| if: steps.release_check.outputs.needs_release != 'true' || inputs.force_release != true |
There was a problem hiding this comment.
3. Wrong changesets if logic 🐞 Bug ✓ Correctness
The updated condition for the changesets-action step uses || inputs.force_release != true, which causes the PR-creation step to run when needs_release is 'true' but force_release is false. This defeats the intent of skipping PR creation when version bumps (and thus a release) are already detected.
Agent Prompt
## Issue description
The changesets-action step gating logic is incorrect. It will run when `needs_release` is `'true'` and `force_release` is not true, which is the opposite of the intended behavior (skip PR creation when a release is already needed).
## Issue Context
`check-if-release.js` explicitly emits `needs_release=true` when version bumps are present.
## Fix Focus Areas
- .github/workflows/release_workspace_version.yml[125-146]
- scripts/ci/check-if-release.js[133-147]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chore: support manually triggering against a workspace + branch (eg., for when orchestrator-1.9 needs an update); also do the prior version release step if needs.check-merged-pr.outputs.needs_release is true
Signed-off-by: Nick Boldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.