Draft
Conversation
theofidry
commented
Feb 23, 2026
|
|
||
| protected function execute(InputInterface $input, OutputInterface $output): int | ||
| { | ||
| $this->errorSymfonyStyle = $output instanceof ConsoleOutputInterface |
Contributor
Author
There was a problem hiding this comment.
there is probably a better way to do this with the Laravel Container... But I'm not familiar with it, and I could not really find it, so meanwhile this works.
|
|
||
| // disable console output in case of json output formatter | ||
| if ($configuration->getOutputFormat() === JsonOutputFormatter::NAME) { | ||
| $this->symfonyStyle->setVerbosity(OutputInterface::VERBOSITY_QUIET); |
Contributor
Author
There was a problem hiding this comment.
so actually this is how it is solved for the JSON output formatter... This makes me wonder if the suggested approach is the correct one.
Basically:
- Should those deprecation warnings be part of the report or not? If yes, then the current design is inadequate as we're just logging stuff to the console instead of passing to the reporter.
- Why is it set to quiet only for JSON? Was it a conscious decision or it actually applies to some but not all output formats?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9673.