Move ImageSource debug helpers out of primitives.h (#58791) - #58791
Open
j-piasecki wants to merge 1 commit into
Open
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122761709. |
facebook-github-tools
Bot
added
p: Software Mansion
Summary: `react/renderer/imagemanager/primitives.h` is public and re-exported by `<React/ImageManager.h>`, but it included the private `react/renderer/debug/debugStringConvertibleUtils.h`. Under `RN_STRICT_API`, any consumer including the umbrella hit the private-header `#error`. Move the bodies of `ImageSource::getDebugProps` and the two `ImageSource::toString` overloads into a new `primitives.cpp`, which includes the private header. The header keeps only the declarations; `SharedDebugStringConvertibleList` is already provided by `<React/RendererDebug.h>`. Changelog: [Internal] Differential Revision: D122761709
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D122761709
branch
from
October 2, 2026 07:56
e47e025 to
da63943
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
react/renderer/imagemanager/primitives.his public and re-exported by<React/ImageManager.h>, but it included the privatereact/renderer/debug/debugStringConvertibleUtils.h. UnderRN_STRICT_API, any consumer including the umbrella hit the private-header#error.Move the bodies of
ImageSource::getDebugPropsand the twoImageSource::toStringoverloads into a newprimitives.cpp, which includes the private header. The header keeps only the declarations;SharedDebugStringConvertibleListis already provided by<React/RendererDebug.h>.Changelog: [Internal]
Differential Revision: D122761709