Remove unused NativeModalManager spec and all related code (#57806) - #57806
Open
christophpurrer wants to merge 1 commit into
Open
Remove unused NativeModalManager spec and all related code (#57806)#57806christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114652881. |
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 5, 2026
Summary: Changelog: [INTERNAL] Remove the dead `NativeModalManager` TurboModule spec and all its dependents — 13 files, 192 deletions across JS spec, Modal.js usage, native registration, CXX API snapshots, blocklist entries, and test mocks. The spec was never implemented and the Modal component no longer needs the event subscription pattern since transitioning to the new renderer. Differential Revision: D114652881
christophpurrer
force-pushed
the
export-D114652881
branch
from
August 5, 2026 02:13
b891ad8 to
78d9a50
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 5, 2026
Summary: Changelog: [INTERNAL] Remove the dead `NativeModalManager` TurboModule spec and all its dependents — 13 files, 192 deletions across JS spec, Modal.js usage, native registration, CXX API snapshots, blocklist entries, and test mocks. The spec was never implemented and the Modal component no longer needs the event subscription pattern since transitioning to the new renderer. Differential Revision: D114652881
christophpurrer
force-pushed
the
export-D114652881
branch
from
August 5, 2026 02:13
78d9a50 to
300acda
Compare
Summary: Pull Request resolved: react#57806 Changelog: [INTERNAL] Remove the dead `NativeModalManager` TurboModule spec and all its dependents — 13 files, 192 deletions across JS spec, Modal.js usage, native registration, CXX API snapshots, blocklist entries, and test mocks. The spec was never implemented and the Modal component no longer needs the event subscription pattern since transitioning to the new renderer. Differential Revision: D114652881
christophpurrer
force-pushed
the
export-D114652881
branch
from
August 5, 2026 02:17
300acda to
3dfd801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [INTERNAL]
Remove the dead
NativeModalManagerTurboModule spec and all its dependents — 13 files, 192 deletions across JS spec, Modal.js usage, native registration, CXX API snapshots, blocklist entries, and test mocks. The spec was never implemented and the Modal component no longer needs the event subscription pattern since transitioning to the new renderer.Differential Revision: D114652881