Skip to content

refactor: use renderable guard for marks #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoyo837 merged 1 commit into from
Sep 3, 2026
+9 −3
Merged

refactor: use renderable guard for marks #1094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"prepare": "husky"
},
"dependencies": {
"@rc-component/util": "^1.11.1",
"@rc-component/util": "^1.13.0",
"clsx": "^2.1.1"
},
"devDependencies": {
Expand Down
10 changes: 8 additions & 2 deletions src/Slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import { isEqual, useControlledState, useEvent, warning } from '@rc-component/util';
import {
isEqual,
isReactRenderable,
useControlledState,
useEvent,
warning,
} from '@rc-component/util';
import { clsx } from 'clsx';
import * as React from 'react';
import Handles, { type HandlesProps, type HandlesRef } from './Handles';
Expand Down Expand Up @@ -234,7 +240,7 @@ const Slider = React.forwardRef<SliderRef, SliderProps<number | number[]>>((prop

return markObj;
})
.filter(({ label }) => label || typeof label === 'number')
.filter(({ label }) => isReactRenderable(label))
.sort((a, b) => a.value - b.value);
}, [marks]);

Expand Down
Loading