VPAAMP-959:[MP4DEMUX]Use codec info from the manifest rather than laz… - #228
Open
varshnie wants to merge 1 commit into
Open
VPAAMP-959:[MP4DEMUX]Use codec info from the manifest rather than laz…#228varshnie wants to merge 1 commit into
varshnie wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GStreamer appsrc source configuration so that, when DRM protection data is already queued, the appsrc caps are rewritten to encrypted (application/x-cenc) caps up-front (instead of relying on later/lazy caps behavior), aligning better with using manifest-derived codec/encryption information.
Changes:
- Detect queued DRM protection events during
InitializeSourceForPlayer()and decide whether encrypted caps should be applied. - When applicable, mutate caps by setting
original-media-type, optionally settingGST_PROTECTION_SYSTEM_ID_CAPS_FIELD, and renaming the caps toapplication/x-cenc. - Add logging to help trace when encrypted caps are applied during source configuration.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vinish100
reviewed
Aug 31, 2026
varshnie
force-pushed
the
feature/VPAAMP-959_PI
branch
from
August 31, 2026 09:19
7a8b607 to
c60e195
Compare
varshnie
force-pushed
the
feature/VPAAMP-959_PI
branch
from
August 31, 2026 10:48
c60e195 to
365183f
Compare
varshnie
force-pushed
the
feature/VPAAMP-959_PI
branch
from
August 31, 2026 11:02
365183f to
bf1fcaa
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
test/utests/tests/InterfacePlayerTests/InterfacePlayerFunctionTests.cpp:843
- After deleting the global g_mockGstUtils, the pointer is left dangling. Because FakeGstUtils checks only for non-null before dispatching, any later call to GetCaps/CreateGstBufferWithData would become a use-after-free and can make tests flaky.
delete g_mockGstUtils;
varshnie
force-pushed
the
feature/VPAAMP-959_PI
branch
from
August 31, 2026 11:28
bf1fcaa to
abd3d2e
Compare
…y caps setting in mp4demux Reason for change:Use codec info from the manifest rather than lazy caps setting in mp4demux Risks: p1 Signed-off-by: varshnie <varshniblue14@gmail.com>
varshnie
force-pushed
the
feature/VPAAMP-959_PI
branch
from
September 3, 2026 06:49
abd3d2e to
03084d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y caps setting in mp4demux
Reason for change:Use codec info from the manifest rather than lazy caps setting in mp4demux Risks: p1