CMakeLists: Export the module targets. Document the changes#96
CMakeLists: Export the module targets. Document the changes#96rbock merged 2 commits intorbock:mainfrom
Conversation
- Cleanup the code that creates the module targets - Rename the module targets to sqlpp23::xxxxx_module - When exporting module targets also export additional information that allows the targets to be imported.
MeanSquaredError
changed the title
MeanSquaredError
force-pushed
the
fix_module_install_4
branch
from
d63ffd6 to
dd9f6b7
Compare
MeanSquaredError
force-pushed
the
fix_module_install_4
branch
from
dd9f6b7 to
11b4326
Compare
|
Fixed a typo in the documentation: specifix -> specific |
docs/setup.md
Outdated
| | sqlpp23::sqlite3 | #include <sqlpp23/sqlite3/sqlite3.h> | The SQLite3 connector as headers | | ||
| | sqlpp23::sqlite3_module | import sqlpp23::sqlite3; | The SQLite3 connector as a module | | ||
|
|
||
| [^1]: The SQLCipher connector re-uses the codebase of the SQLite3 connector. |
There was a problem hiding this comment.
foot notes 1 and 2 seem to be swapped?
There was a problem hiding this comment.
Indeed I somehow missed that! That should be fixed now.
…scriptions of the module targets.
MeanSquaredError
force-pushed
the
fix_module_install_4
branch
from
11b4326 to
689a03f
Compare
|
Thanks for the changes, LGTM! |
|
Great! That concludes pretty much all the changes related to modules, that I had in mind. So right now sqlpp23 is one of the few libraries that fully support modules (modulo any bugs that the recent changes may have introduced :-) |
|
I probably don't say this often enough: Thanks for your continued support! I really appreciate you pushing for it. |
|
@rbock |
2 participants
This PR exports the CMake module targets and documents them. I built and tested it with
(all connectors included, modules disabled)
and
(all connectors included, modules enabled)
So hopefully it doesn't break anything.
The test targets could be renamed or aliased as well to make their names more in-line with the names of the module targets, but that's not urgent and can wait until someone finds the time to do that :-)