Main#8
Open
u19809 wants to merge 7 commits into
Open
Conversation
Updated README to reflect project name change and backend support details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this version implements the following changes
there is one tricky point though : sorted and unsorted json. Nlohmann supports both qjson does not. Luckily the templated API should be able to support both
there are some conflicts with your latest version. Most are due to the fact that to factor out nlohmann I created a jsonata::ordered_map to eliminate the use of nlohmann::ordered_map. So that conflict is easy except for one location with respect to your regex change. I think replacing nlohmann::ordered_map with jsonata::ordered_map is safe but I leave it up to you to give the green light.