Skip concurrency controls for jobs whose class has been removed#717
Merged
Skip concurrency controls for jobs whose class has been removed#717
Conversation
rosa
force-pushed
the
fix-missing-job-class-blocks-queue
branch
from
4622fbe to
44805d2
Compare
When a job's class is removed from the codebase (e.g. during a deploy), any enqueued jobs with concurrency controls would crash the worker because `concurrency_limited?` returned true based solely on the presence of a `concurrency_key`, then delegates like `concurrency_limit` and `concurrency_duration` would blow up on the nil `job_class`. By also checking that `job_class` is present, we let these jobs bypass concurrency controls entirely. They get dispatched normally, fail at `ActiveJob::Base.execute` with a NameError, and become FailedExecutions — instead of blocking the entire queue. Fixes #522 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rosa
force-pushed
the
fix-missing-job-class-blocks-queue
branch
from
44805d2 to
e08d106
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a job's class is removed from the codebase (e.g. during a deploy), any enqueued jobs with concurrency controls would crash the worker because
concurrency_limited?returned true based solely on the presence of aconcurrency_key, then delegates likeconcurrency_limitandconcurrency_durationwould blow up on the niljob_class.By also checking that
job_classis present, we let these jobs bypass concurrency controls entirely. They get dispatched normally, fail atActiveJob::Base.executewith aNameError, and becomeFailedExecutionsinstead of blocking the entire queue.Fixes #522