perf(callstack): Working set query backed by native thread pool#647
Open
rabbitstack wants to merge 1 commit intomasterfrom
Open
perf(callstack): Working set query backed by native thread pool#647rabbitstack wants to merge 1 commit intomasterfrom
rabbitstack wants to merge 1 commit intomasterfrom
Conversation
Introduce a fixed-size native OS thread pool to isolate QueryWorkingSetEx from the Go scheduler. Each worker thread loops on WaitForMultipleObjects([in, quit]) so the pool can be shut down cleanly without TerminateThread, returning locked goroutines and OS threads to the runtime on close.
1fb50b0 to
076e72a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Introduce a fixed-size native OS thread pool to isolate QueryWorkingSetEx from the Go scheduler. Each worker thread loops on
WaitForMultipleObjects([in, quit])so the pool can be shut down cleanly withoutTerminateThread, returning locked goroutines and OS threads to the runtime on close.What type of change does this PR introduce?
/kind improvement
Any specific area of the project related to this PR?
/area instrumentation
Special notes for the reviewer
Does this PR introduce a user-facing change?