Extract quickfixj-codegenerator into standalone Maven plugin module#1185
Draft
Extract quickfixj-codegenerator into standalone Maven plugin module#1185
Conversation
…version 3.0.1-SNAPSHOT Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/85fd221c-3dd7-4c8b-8a04-abdde5552693 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Extract quickfixj-codegenerator Maven plugin into standalone module
Extract quickfixj-codegenerator into standalone Maven plugin module
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts
quickfixj-codegeneratorfrom thequickfix-j/quickfixjmulti-module build into a self-contained, independently releasable Maven plugin module at version3.0.1-SNAPSHOT— the same pattern applied toquickfixj-class-pruner-maven-pluginin PR #1184.quickfixj-codegenerator/pom.xml
<parent>block; added standalone<groupId>,<version>,<licenses>,<developers>,<scm>,<issueManagement>,<prerequisites><properties><build><pluginManagement>for compiler, source, javadoc, gpg, nexus-staging pluginsjava-8-compilation(JDK ≥ 9 activatesmaven.compiler.release=8),release,sign<distributionManagement>targeting GitHub Packages (snapshots) and OSSRH (releases)New files in quickfixj-codegenerator/
.github/workflows/maven.yml— CI matrix: ubuntu + macOS-14 × JDK 8/11/21.gitignore— standard Maven/IDE ignoresLICENSE— QuickFIX Software License v1.0Root pom.xml
<module>quickfixj-codegenerator</module><codegenerator-plugin.version>3.0.1-SNAPSHOT</codegenerator-plugin.version>propertypluginManagemententry pinning the plugin to${codegenerator-plugin.version}Downstream references
quickfixj-messages-all/pom.xmlandquickfixj-distribution/pom.xml: codegenerator version changed from${project.version}→${codegenerator-plugin.version}.github/workflows/nightly-build.yml: removedorg.quickfixj.quickfixj-codegeneratorfrom the "Delete old packages" stepOriginal prompt
Goal
Extract the
quickfixj-codegeneratorMaven plugin from thequickfix-j/quickfixjmulti-module build into a standalone, self-contained module — exactly the same pattern as was done forquickfixj-class-pruner-maven-pluginin PR #1184.The standalone version should be
3.0.1-SNAPSHOT.Changes required
1. Transform
quickfixj-codegenerator/pom.xmlinto a standalone POMRemove the
<parent>block and make it a fully self-contained POM:<groupId>org.quickfixj</groupId><version>3.0.1-SNAPSHOT</version><licenses>block (The QuickFIX Software License, Version 1.0, http://www.quickfixj.org/documentation/license.html)<developers>block: id=chrjohn, name=Christoph John<scm>block pointing tohttps://github.com/quickfix-j/quickfixj-codegenerator<issueManagement>block pointing tohttps://github.com/quickfix-j/quickfixj-codegenerator/issues<prerequisites><maven>3.9.12</maven></prerequisites><properties>, add all version properties explicitly (don't rely on parent):project.build.sourceEncoding= UTF-8project.reporting.outputEncoding= UTF-8maven.compiler.source= 8maven.compiler.target= 8maven-libs-version= 3.9.12maven-plugin-api-version= 3.9.14maven-plugin-annotations.version= 3.15.2junit.jupiter.version= 5.14.3commons-io.version= 2.21.0maven-surefire-plugin-version= 3.5.5maven-compiler-plugin-version= 3.15.0maven-source-plugin-version= 3.4.0maven-javadoc-plugin-version= 3.12.0maven-gpg-plugin-version= 3.2.8nexus-staging-maven-plugin-version= 1.7.0<dependency>entries that used to inherit versions from parent, add explicit<version>tags using the above properties<build><pluginManagement>section that defines explicit versions for: maven-compiler-plugin (with<forceLegacyJavacApi>true</forceLegacyJavacApi>), maven-source-plugin (with attach-sources execution), maven-javadoc-plugin (with attach-javadocs execution,<quiet>true</quiet><doclint>none</doclint>), maven-gpg-plugin (with sign-artifacts execution), nexus-staging-maven-plugin (with ossrh configuration)<profiles>section with:java-8-compilationprofile (activated on JDK >= 9, setsmaven.compiler.release=8)releaseprofile (activates maven-source-plugin, maven-javadoc-plugin, nexus-staging-maven-plugin)signprofile (activates maven-gpg-plugin)<distributionManagement>:<snapshotRepository>id=github, url=https://maven.pkg.github.com/quickfix-j/quickfixj-codegenerator<repository>id=ossrh, url=https://oss.sonatype.org/service/local/staging/deploy/maven2/2. Add
quickfixj-codegenerator/.github/workflows/maven.ymlCreate this file:
3. Add
quickfixj-codegenerator/.gitignoreCreate this file:
4. Add
quickfixj-codegenerator/LICENSECopy the existing LICENSE text used in the class-pruner plugin (The QuickFIX Software License, Version 1.0).
5. Update root
pom.xml<module>quickfixj-codegenerator</module>from the<modules>section<codegenerator-plugin.version>3.0.1-SNAPSHOT</codegenerator-plugin.version>to the<properties>section<plugin>entry in<build><pluginManagement><plugins>for the codegenerator:6. Update
quickfixj-messages/quickfixj-messages-all/pom.xmlChange the codegenerator plugin version from
${project.version}to${codegenerator-plugin.version}: