refactor(definitions.typ): use single rule for definition item#14128
Merged
gordonwoodhull merged 1 commit intoquarto-dev:mainfrom Mar 3, 2026
Merged
refactor(definitions.typ): use single rule for definition item#14128gordonwoodhull merged 1 commit intoquarto-dev:mainfrom
gordonwoodhull merged 1 commit intoquarto-dev:mainfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
cderv
approved these changes
Mar 3, 2026
Collaborator
cderv
left a comment
There was a problem hiding this comment.
Test are passing, and it is already merged upstream. Seems ok to merge for 1.9.
@gordonwoodhull what do you think ?
Contributor
|
Absolutely. Took me a minute to understand, because I thought we had already done this. But this is something we discussed after merging #13978, but never implemented here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the item display rule.
Follow up on:
Upstream: