Update .dockerignore, .gitignore, and .geminiignore - #1082
Open
mhucka wants to merge 12 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates .dockerignore and .geminiignore to include additional generic ignore patterns (such as backup files, logs, and caches) and Emacs versioned backup files, respectively. There are no review comments, so I have no feedback to provide.
github-actions
Bot
added
size: M
Collaborator
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request expands the .dockerignore and .geminiignore files to exclude various temporary files, IDE settings, build outputs, and editor backups. The feedback suggests modifying the *.tar.gz pattern in .dockerignore to **/*.tar.gz to ensure consistency with other patterns and to correctly ignore compressed archives located in subdirectories.
mhucka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Greatly revises
.dockerignoreto be more selective and handle more cases on different platforms.Removes some things from
.gitignorethat this project doesn't use.Adds a pattern for Emacs version backups to
.geminiignore. It should not be needed because there's a pattern in.gitignorethat handles it, but Gemini doesn't seem to interpret that pattern as expected. Though the best practice for Emacs users is to configure their editor to put checkpoint files outside the source directory, sometimes they may not. In those cases, adding this pattern avoids an easy-to-miss cause of problems when using Gemini CLI.