Add support to take bounding box info from metadata passed from the level-1 reader#724
Add support to take bounding box info from metadata passed from the level-1 reader#724adybbroe wants to merge 2 commits into
Conversation
… instead of calculating it from the geolocation data Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
| mask = thelons.notnull().compute() | ||
| thelons = thelons.where(mask, drop=True) | ||
|
|
||
| thelats = self.lats[:, int(cols / 2)] | ||
| thelats = thelats.where(thelats.notnull(), drop=True) | ||
| mask = thelats.notnull().compute() | ||
| thelats = thelats.where(mask, drop=True) |
There was a problem hiding this comment.
It would be good to do the compute at the same time like thelons, thelats = da.compute(thelons.notnull(), thelats.notnull()). That way any shared computation tasks are only run once.
There was a problem hiding this comment.
It would be good to do the compute at the same time like
thelons, thelats = da.compute(thelons.notnull(), thelats.notnull()). That way any shared computation tasks are only run once.
Fixed, thanks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 93.66% 93.59% -0.07%
==========================================
Files 89 89
Lines 13707 13735 +28
==========================================
+ Hits 12838 12855 +17
- Misses 869 880 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
2 participants
Add support to take bounding box info from metadata in the area object instead of calculating it from the geolocation data