Check Result before calling .get() on method_meta in getUsedBackends#17607
Check Result before calling .get() on method_meta in getUsedBackends#17607kirklandsign wants to merge 1 commit intomainfrom
Conversation
`getUsedBackends()` called `module_->method_meta(...).get()` without checking if the Result was ok, which is undefined behavior on error. Add an `.ok()` check and throw IllegalArgumentException on failure, consistent with how `method_names()` handles its Result above.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17607
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Unrelated FailureAs of commit ffc5e03 with merge base cf08087 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Summary
getUsedBackends()calledmodule_->method_meta(...).get()without checking if the Result was ok, which is undefined behavior on error. Add an.ok()check and throw IllegalArgumentException on failure, consistent with howmethod_names()handles its Result above.Test plan
CI