[yt-dlp] Add typing for postprocessor_hooks#15810
Open
Soulsuck24 wants to merge 1 commit into
Open
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
requested changes
May 20, 2026
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thanks! A few optional requests:
- Could you copy the hook signature to
YoutubeDL.add_progress_hook? - Also I noticed, there's something called
post_hookswhich is also missing. Could you add that? It's fine to leave it aspost_hooks: Iterable[Callable[[Incomplete], object]for now if you don't want to dig into what argument that takes.
| write_pages: bool | None | ||
| external_downloader_args: Literal["default"] | Mapping[str, Collection[str]] | Collection[str] | None | ||
| postprocessor_args: Mapping[str, Collection[str]] | Collection[str] | None | ||
| postprocessor_hooks: list[Callable[[dict[str, Any]], object]] | None |
Collaborator
There was a problem hiding this comment.
As far as I can see, this can not be None. Also, it works with any Iterable:
Suggested change
| postprocessor_hooks: list[Callable[[dict[str, Any]], object]] | None | |
| postprocessor_hooks: Iterable[Callable[[dict[str, Any]], object]] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds typing for postprocessor_hooks in init.pyi