Make filename, stream, and handlers parameters of logging.basicConfig mutually-exclusive#15435
Merged
srittau merged 3 commits intopython:mainfrom Feb 18, 2026
Conversation
Collaborator
Author
|
cc @hamdanal since you looked at this function recently |
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Feb 17, 2026
Collaborator
There was a problem hiding this comment.
This sounds like a case where we could forbid filemode to prevent an error where users pass it, expecting to do something when it doesn't. But I don't have strong feelings either way.
Collaborator
Author
There was a problem hiding this comment.
Sounds reasonable. The same is actually true for encoding and errors as well (all three do nothing when filename is not specified), so I think I'll remove all three from the overloads that don't include filename
srittau
approved these changes
Feb 17, 2026
Collaborator
srittau
left a comment
There was a problem hiding this comment.
LGTM, with one potential comment.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reference:
Source: https://github.com/python/cpython/blob/3.14/Lib/logging/__init__.py#L2005
Docs: https://docs.python.org/3/library/logging.html#logging.basicConfig