Straighten interface/implementation boundary#21270
Merged
ilevkivskyi merged 4 commits intopython:masterfrom Apr 20, 2026
Merged
Straighten interface/implementation boundary#21270ilevkivskyi merged 4 commits intopython:masterfrom
ilevkivskyi merged 4 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Apr 20, 2026
| change this in future by adding a special kind of Any that signifies not ready type. | ||
|
|
||
| Second important aspect of architecture is two-phase checking. Currently, it is only | ||
| used in parallel type-checking mode, but at some point it will the default in sequential |
Collaborator
There was a problem hiding this comment.
Missing word: will be the default
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #21119
This avoids type-checking function signatures twice in two-phase checking. Luckily, things where already quite clean, only overloads needed some non-trivial logic (I guess this is why the daemon checks overloads as a whole). Some comments:
impl_only=Truein the daemon (or actually just remove this flag altogether).__iadd__()and__radd__(), I just added TODOs for now, as these looks quite niche use cases.checker.py.cc @JukkaL