gh-156439: Gate socket.if_{nametoindex, indextoname} on respective OS capability - #156708
Open
A5rocks wants to merge 3 commits into
Open
gh-156439: Gate socket.if_{nametoindex, indextoname} on respective OS capability#156708A5rocks wants to merge 3 commits into
A5rocks wants to merge 3 commits into
Conversation
A5rocks
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
August 31, 2026 12:55
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
| #endif | ||
|
|
||
| #endif /*Py_PYCONFIG_H*/ | ||
|
|
Member
There was a problem hiding this comment.
Why did we lose this line?
Author
There was a problem hiding this comment.
Probably because I copied the diff from GitHub Actions and my editor removes trailing newlines... oops!
Co-authored-by: Stan Ulbrych <stan@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not exactly a C programmer so hopefully I'm approaching this the correct way?
if_indextonameandif_nametoindexwithoutif_nameindex, but socket doesn't expose that #156439