gh-43720: IDLE - use tk text print when available#153744
Open
terryjreedy wants to merge 2 commits into
Open
Conversation
The new tk print command is available in tk 9.0. When running tk 8.6, fall back to old code.
terryjreedy
added
needs backport to 3.13
terryjreedy
changed the title
| def print_window(self, event): | ||
| try: | ||
| self.text.tk.call('tk', 'print', self.text) | ||
| except tkinter.TclError: |
Member
There was a problem hiding this comment.
There is no tkinter import here.
Larger issue is that this catches all TclError; if tk print exists but fails mid-print, it will silently pop up a second dialog. I suggest to check for "unknown subcommand" in the error message, or, better, test the Tk version. Anyway, you need to handle TclError in tk_print() if they are not already handled at higher level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.