gh-49288: Reset file-like POST body on HTTP auth retry#153726
Open
orsenthil wants to merge 4 commits into
Open
gh-49288: Reset file-like POST body on HTTP auth retry#153726orsenthil wants to merge 4 commits into
orsenthil wants to merge 4 commits into
Conversation
Wrap seekable file-like Request.data in a re-iterator before Basic and Digest authentication retries so the POST body is resent after a 401. Non-seekable streams raise ValueError instead of sending an empty body.
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix long-standing bug where HTTP Basic/Digest auth retries send an empty POST body when
Request.datais a consumed file-like object (e.g.mmap.mmap, open file,BytesIO).Fixes gh-49288.