Skip to content

gh-130555: Fix use-after-free in dict.clear() with embedded values#145268

Merged
colesbury merged 1 commit intopython:mainfrom
colesbury:gh-130555-dict-clear-reentrancy
Mar 2, 2026
Merged

gh-130555: Fix use-after-free in dict.clear() with embedded values#145268
colesbury merged 1 commit intopython:mainfrom
colesbury:gh-130555-dict-clear-reentrancy

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Feb 26, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 26, 2026
Closed
@colesbury colesbury added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Feb 26, 2026
@bedevere-bot
Copy link

bedevere-bot commented Feb 26, 2026

🤖 New build scheduled with the buildbot fleet by @colesbury for commit d4bc6e8 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145268%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 26, 2026
@colesbury colesbury marked this pull request as ready for review February 26, 2026 20:02
@colesbury colesbury requested review from DinoV and mpage February 26, 2026 20:02
@colesbury colesbury merged commit 02288bf into python:main Mar 2, 2026
72 checks passed
@colesbury colesbury deleted the gh-130555-dict-clear-reentrancy branch March 2, 2026 17:25
@miss-islington-app
Copy link

miss-islington-app bot commented Mar 2, 2026

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Mar 2, 2026

Sorry, @colesbury, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 02288bf0225bea892eaab0d3e13c271761849e22 3.14

@miss-islington-app
Copy link

miss-islington-app bot commented Mar 2, 2026

Sorry, @colesbury, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 02288bf0225bea892eaab0d3e13c271761849e22 3.13

colesbury added a commit to colesbury/cpython that referenced this pull request Mar 2, 2026
@colesbury
[3.14] pythongh-130555: Fix use-after-free in dict.clear() with embed…
6422340 
…ded values (pythongh-145268)

(cherry picked from commit 02288bf)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 2, 2026

GH-145430 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 2, 2026
colesbury added a commit to colesbury/cpython that referenced this pull request Mar 2, 2026
@colesbury
[3.13] pythongh-130555: Fix use-after-free in dict.clear() with embed…
101b03d 
…ded values (pythongh-145268)

(cherry picked from commit 02288bf)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 2, 2026

GH-145431 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 2, 2026
colesbury added a commit that referenced this pull request Mar 2, 2026
@colesbury
[3.14] gh-130555: Fix use-after-free in dict.clear() with embedded va…
7f9fcba 
…lues (gh-145268) (#145431)
colesbury added a commit that referenced this pull request Mar 2, 2026
@colesbury
[3.13] gh-130555: Fix use-after-free in dict.clear() with embedded va…
d567f45 
…lues (gh-145268) (#145430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpage mpage mpage approved these changes

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@DinoV DinoV Awaiting requested review from DinoV

Assignees

@colesbury colesbury

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury @bedevere-bot @mpage