gh-130273: Fix traceback color output with unicode characters#142529
Open
grayjk wants to merge 4 commits intopython:mainfrom
Open
gh-130273: Fix traceback color output with unicode characters#142529grayjk wants to merge 4 commits intopython:mainfrom
grayjk wants to merge 4 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
Member
|
@serhiy-storchaka: Here is a PR about text width and Unicode characters :-) |
Contributor
Author
|
updated to use @serhiy-storchaka's recently added unicodedata.iter_graphemes |
Contributor
Author
|
@pablogsal @hauntsaninja as recent reviewers of traceback.py, would you mind taking look |
Member
|
There are conflicts, please fix them. |
Contributor
Author
|
@StanFromIreland conflicts resolved |
vstinner
reviewed
Feb 19, 2026
| 2 if unicodedata.east_asian_width(char) in _WIDE_CHAR_SPECIFIERS else 1 | ||
| for char in line[:offset] | ||
| ) | ||
| from _pyrepl.utils import wlen |
Member
There was a problem hiding this comment.
I would prefer to not depend on _pyrepl in the traceback module. I would prefer to move wlen() here, and modify _pyrepl.utils to get it from traceback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Account for the display width of unicode characters so that colors and underlining in traceback output is correct
Closes #130273