Skip to content

Add wait_closed to the threading implementation. - #1754

Merged
aaugustin merged 1 commit into
mainfrom
sync-wait_closed
Aug 29, 2026
Merged

Add wait_closed to the threading implementation.#1754
aaugustin merged 1 commit into
mainfrom
sync-wait_closed

Conversation

@aaugustin

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds wait_closed() to synchronous connections, aligning lifecycle waiting with the asynchronous implementations.

Changes:

  • Adds timeout-aware synchronous connection closure waiting.
  • Adds coverage for blocking, successful, and timed-out waits.
  • Documents the API and updates related test naming.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/websockets/sync/connection.py Implements wait_closed().
tests/sync/test_connection.py Tests closure-wait behavior.
tests/asyncio/test_connection.py Clarifies waiter naming.
tests/trio/test_connection.py Clarifies waiter naming.
docs/reference/sync/connection.rst Lists the new base API.
docs/reference/sync/client.rst Lists the inherited client API.
docs/reference/sync/server.rst Lists the inherited server API.
docs/project/changelog.rst Records the feature.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@aaugustin
aaugustin merged commit d4f9a2b into main Aug 29, 2026
9 checks passed
@aaugustin
aaugustin deleted the sync-wait_closed branch August 29, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants