Skip to content

Refactor argparse custom#1621

Merged
kmvanbrunt merged 14 commits intomainfrom
refactor_argparse_custom
Apr 1, 2026
Merged

Refactor argparse custom#1621
kmvanbrunt merged 14 commits intomainfrom
refactor_argparse_custom

Conversation

@kmvanbrunt
Copy link
Copy Markdown
Member

@kmvanbrunt kmvanbrunt commented Apr 1, 2026

  • Require devs to use Cmd2ArgumentParser-based parsers.
  • Moved previously-patched functions into Cmd2ArgumentParser.
  • Simplified creation of cmd2-specific argparse.Action attributes.
  • Made common prefix for all private cmd2 attributes.

@kmvanbrunt kmvanbrunt requested a review from tleonhardt as a code owner April 1, 2026 05:15
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (b726c52) to head (95be12b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
+ Coverage   99.51%   99.57%   +0.05%     
==========================================
  Files          21       21              
  Lines        4766     4715      -51     
==========================================
- Hits         4743     4695      -48     
+ Misses         23       20       -3     
Flag Coverage Δ
unittests 99.57% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tleonhardt
tleonhardt previously approved these changes Apr 1, 2026
Copy link
Copy Markdown
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmvanbrunt kmvanbrunt merged commit d404476 into main Apr 1, 2026
33 checks passed
@kmvanbrunt kmvanbrunt deleted the refactor_argparse_custom branch April 1, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants