Skip to content

fix: issue with example code#549

Open
mats-knmi wants to merge 2 commits into
masterfrom
fix-548
Open

fix: issue with example code#549
mats-knmi wants to merge 2 commits into
masterfrom
fix-548

Conversation

@mats-knmi
Copy link
Copy Markdown
Contributor

@mats-knmi mats-knmi commented May 11, 2026

Fixes #548

Looks like if you pass it a nowcast with only a single member the nan mask will not have the correct shape at the time it is used. This is because a single member gets repeated to match the number of members expected. Now the same happens for the nan mask.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.17%. Comparing base (aa8de93) to head (46ba953).

Files with missing lines Patch % Lines
pysteps/blending/steps.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
- Coverage   84.18%   84.17%   -0.01%     
==========================================
  Files         170      170              
  Lines       14984    14985       +1     
==========================================
  Hits        12614    12614              
- Misses       2370     2371       +1     
Flag Coverage Δ
unit_tests 84.17% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mats-knmi, I can confirm that the fix solves the regression described in #548

edit: I'm a bit concerned we didn't capture this with our tests, should we include this test case too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs build fails in blended forecast example after #546

2 participants