Repository navigation
Revert #788 and #794 to restore the original publish behavior - #799
Open
thomashoneyman wants to merge 2 commits into
Open
thomashoneyman wants to merge 2 commits into
thomashoneyman wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #797.
Instead of keeping #788 and just adjusting the duplicate detection, this reverts both #788 and #794 so we're back to a clean slate. We can then reopen #788 and do a better replacement of #794. I've left the targeted fix open along with this full rollback so we can decide which one we want to do.
This returns publish submissions to the old behavior: for a package name and version, return the oldest existing job, even if it failed. That restores the protection against repeated (automated) publishing and stops resubmission from being a way to change a tag and try again. Unlike #797, this also removes the atomic publish lookup and insert, the additional publication checks, and the structured job outcomes from #788.
The database migration has already run in production; this isn't a problem, we can merge this without any changes -- the new columns are simply ignored. Already did a little manual check there. However, the cleanest revert would be to stop the server, roll back migration 20260722000000, remove the failed puppy-runtime@0.2.0 job, and then start the server. I can do that if we don't intend to bring #788 back as-is.