[PULP-2199] Add SLSA attestation verification support - #1327
Open
jobselko wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
no-changelog
no-issue
multi-commit
jobselko
force-pushed
the
att_patch
branch
3 times, most recently
from
August 18, 2026 14:47
3eb2c02 to
0f36075
Compare
jobselko
changed the title
jobselko
marked this pull request as ready for review
August 20, 2026 14:29
Member
Author
|
The first commit contains the applied patch and tests, the second covers the changes needed to upstream it. I will squash them at the end. |
gerrod3
reviewed
Aug 20, 2026
gerrod3
left a comment
gerrod3
left a comment
Contributor
There was a problem hiding this comment.
I'm having second thoughts about moving this patch over. I think we should spend some more time thinking about the feature and what would be useful to more people.
| standard Sigstore path. Attestations without certificates are verified | ||
| against a custom public key configured via ATTESTATION_VERIFICATION_KEY. | ||
| Currently, it supports RSA PKCS1v15 signatures and SLSA v0.2 provenance | ||
| publisher enrichment. |
Contributor
There was a problem hiding this comment.
The publisher enrichment is technically a side-effect of the method. Not sure it's the best thing to copy.
| stmt = _verify_statement_subject(attestation, dist) | ||
| _enrich_publisher_from_statement(stmt, publisher) | ||
| if verification_key: | ||
| _verify_signature(attestation, verification_key) |
Contributor
There was a problem hiding this comment.
Only one key to verify against across all repositories and all domains. I wonder if we could do something better. What services has is custom built for their use-case, so I don't really want to just move it over as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Checklist
See: Pull Request Walkthrough