Histogram spec: Rework and amend operators section#2823
Open
Conversation
- Divide operators section into sub-sections and reformat accordingly. - Add that negative results of multiplication count as gauge histogram. - Correct and complete the sub-section about trim operators. Signed-off-by: beorn7 <beorn@grafana.com>
beorn7
force-pushed
the
beorn7/histogram
branch
from
1e4e058 to
fb815fc
Compare
Member
Author
|
Now that we have nailed down what to do in prometheus/prometheus#17904 , we can finalize this. @krajorama & @linasm what do you think about this? I'm wondering how detailed we should describe the edge cases in the spec (or pseudo-spec, as I prefer to call it) here. One could argue that they are all implied with the current wording, but another line of argument would say we should spell out the edge cases here explicitly. (I currently tend towards the former, as it is more in line with the other parts of this document.) |
Member
Author
|
As per discussion over on prometheus/prometheus#17904, I'll add a detailed edge case description here (hopefully tomorrow). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Divide operators section into sub-sections and reformat accordingly.
Add that negative results of multiplication count as gauge histogram.
Correct and complete the sub-section about trim operators.