Skip to content

Update benchmark baseline to latest release. #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdmarshall wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −9
Open

Update benchmark baseline to latest release. #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
- perf: Remove object and array fallback truthiness from core metric paths
- fix: Non-nullish, non-string label values are coerced to strings when a combination is first stored, so exposition escapes them; the store also keeps its own copy, so mutating the caller's object after recording no longer changes the stored series
- fix: Label-less summaries report `labels: {}` in `getMetricsAsJSON()`, like other metrics (Fixes [#838](https://github.com/prometheus/client_js/issues/838))
- chore: update benchmark baseline to v0.16.1

### Added

Expand Down
3 changes: 1 addition & 2 deletions benchmarks/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ const Benchmark = require('faceoff').default;
*/

const benchmarks = new Benchmark({
// TODO: Update this once the module is published to as @prometheus-io/client.
latest: 'prom-client@latest',
latest: '@prometheus-io/client',
trunk: 'git@github.com:prometheus/client_js',
current: { location: process.cwd() },
});
Expand Down
9 changes: 3 additions & 6 deletions benchmarks/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ const Path = require('path');
module.exports = setupUtilSuite;

function setupUtilSuite(suite) {
const skip = ['latest'];

suite.add(
'hashObject',
(client, Util) => {
Expand All @@ -33,7 +31,7 @@ function setupUtilSuite(suite) {
phase: 'load',
});
},
{ setup: findUtil, skip },
{ setup: findUtil },
);

suite.add(
Expand All @@ -49,7 +47,7 @@ function setupUtilSuite(suite) {
label1: 4,
});
},
{ setup, skip },
{ setup },
);

suite.add(
Expand All @@ -65,7 +63,7 @@ function setupUtilSuite(suite) {
label1: 4,
});
},
{ setup, skip },
{ setup },
);

suite.add(
Expand All @@ -91,7 +89,6 @@ function setupUtilSuite(suite) {

return new Util.LabelGrouper();
},
skip: ['latest', 'trunk'],
},
);
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"eslint-plugin-n": "^18.3.0",
"eslint-plugin-prettier": "^5.0.1",
"express": "^5.1.0",
"faceoff": "^1.3.0",

@jdmarshall jdmarshall Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3 has a math bug that reports regressions a hair under 5% (1.00/1.05 instead of 95%), which gets confusing due to rounding errors, that some tests show in the regression while others do not. This was fixed as adding a feature to report a specific range as 'slow' instead of defaulting to 5% (or 4.76%)

"faceoff": "^1.4.0",
"globals": "^16.2.0",
"husky": "^9.0.0",
"jest": "^30.0.2",
Expand Down
Loading