Skip to content

Refactor global node handling and add millis function#8530

Open
perminder-17 wants to merge 1 commit intoprocessing:dev-2.0from
perminder-17:Adding-millis()
Open

Refactor global node handling and add millis function#8530
perminder-17 wants to merge 1 commit intoprocessing:dev-2.0from
perminder-17:Adding-millis()

Conversation

@perminder-17
Copy link
Collaborator

Resolves #8474

Changes:

Added support for millis(),

Here's the result.
https://editor.p5js.org/aman12345/sketches/YPHvvipq7

In the code side we are doing nothing but

getOrCreateUniformNode: This function checks if a StrandsNode for a given uniform already exists. If it exists, it returns the cached node. If it doesn’t, it registers the uniform in strandsContext.uniforms (only once), builds the IR variable node, wraps it using createStrandsNode to make a StrandsNode, stores it in the cache, and returns it.

Using the same function as an helper for getBuiltinGlobalNode as we do same stuffs there for global property like mouseX etc.

PR Checklist

@perminder-17
Copy link
Collaborator Author

Adding reviewer: @Satish11012007 and @Anshumancanrock since you were interested in contributing. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant