feat(webgl): add global property support for p5.strands by avinxshKD · Pull Request #8211 · processing/p5.js

avinxshKD · 2025-10-27T19:44:14Z

Resolves #8171

Changes:

What was changed:

Modified src/strands/strands_api.js to automatically intercept 16 p5 global properties when strands is active
Properties are automatically converted to uniforms with callbacks to their live values
Implemented proper context restoration when strands becomes inactive

Screenshots of the change:
N/A - This is an API enhancement without visual changes.

PR Checklist

npm run lint passes
Inline reference is included / updated
Unit tests are included / updated

avinxshKD · 2025-11-10T14:41:29Z

hey @davepagurek, kindly review this too when you get a chance

davepagurek

Hi, sorry for the delay, we were busy getting the 2.1 release out. Now that that's done, I can give an actual review! Your general approach looks good.

Do you think you can add some unit tests that make use of these globals so we can both verify that it works, and also help ensure that it doesn't break in the future after other changes?
It would also be great to put up a test sketch in the p5 web editor to play around with and help find bugs. To do that, you can run npm run build, upload lib/p5.js to a web editor sketch, and edit its p5 script tag in index.html to point to your uploaded file.

davepagurek · 2025-11-12T22:37:16Z

src/strands/strands_api.js

While this is an integer value, it's fairly unintuitive for users of strands for it to actually be a glsl int instead of a float, since in JS all numbers are floats, and you'd expect frameCount / 2 to have decimals sometimes. So maybe let's turn all the ints into floats here?

davepagurek · 2025-11-12T22:38:09Z

src/strands/strands_api.js

In p5 2.x this isn't an int, it's an object: https://beta.p5js.org/reference/p5/mousebutton/ We might need to special case this one by either making each property a uniform, or by just omitting it for now.

@davepagurek

- Changed frameCount from int1 to float1 for JS compatibility - Removed mouseButton (object type in p5 2.x) - Added unit tests for all 14 global properties Addresses feedback from @davepagurek in processing#8211

avinxshKD · 2025-11-24T09:15:06Z

Hey @davepagurek, made the necessary changes. Please review whenever you get a chance.

davepagurek · 2026-01-04T19:47:29Z

Hi! Sorry for the delay on this, we've been busy getting some other changes out. I'm back now to dedicate full attention to this if you're still interested in continuing!

You should try running the tests on your PR, as it will surface issues faster than my reviews will. Running the tests on this, there are a number of test failures currently. In existing tests, the code breaks because the width property is being redefined. We may need to remove the old property before adding a new property descriptor. Additionally, the new tests added are failing because p5 is not defined in them.

perminder-17 · 2026-01-25T18:21:56Z

test/unit/webgl/p5.Shader.js

Is this test enough? do you suggest adding unit tests as well? @davepagurek

maybe we could add a visual test that makes use of e.g. width and height?

maybe we could add a visual test that makes use of e.g. width and height?

Aah yes, I mean visual tests.

Removed redundant assertions for mxInHook and wInHook.

davepagurek

one other thought: could we add support for millis() too?�im trying to think if there are other things like it which are functions, not properties, that should also be added. maybe thats it though

perminder-17 · 2026-01-26T21:00:34Z

one other thought: could we add support for millis() too?�im trying to think if there are other things like it which are functions, not properties, that should also be added. maybe thats it though

Yes, I really like the idea of adding millis() too, but I’m a bit concerned about the scope of this PR. Since the title is “add global property support for p5.strands,”. Do you think we should include millis() support in this PR, or would it be better to handle it in a follow-up PR specifically for global function support in p5.strands?

Add visual test for getFinalColor using width/height

davepagurek · 2026-01-27T19:57:54Z

test/unit/webgl/p5.Shader.js

One last thing for this before merging, these variables don't get assigned to -- the callback in modify has no access to these due to our transpilation process. Currently it'd effectively be assigning to a global variable. We should probably remove these lets and then declare them locally in the shader to avoid confusion.

davepagurek · 2026-01-27T19:58:41Z

@perminder-17 a separate PR is ok!

avinxshKD · 2026-01-28T04:51:25Z

Sorry for the delay, I was away for exams .....really thanks @perminder-17 @davepagurek for the help, pls let me know if there's anything left for me to fix to get this merged asap

perminder-17 · 2026-01-31T22:00:27Z

Sorry for the delay, I was away for exams .....really thanks @perminder-17 @davepagurek for the help, pls let me know if there's anything left for me to fix to get this merged asap

Thanks for your work on this @avinxshKD! I pushed a few additional commits directly to your PR to help move things along, but your original commits are unchanged and still credited to you.

davepagurek · 2026-02-01T19:15:51Z

@all-contributors please add @avinxshKD for code

allcontributors · 2026-02-01T19:16:16Z

@davepagurek

I've put up a pull request to add @avinxshKD! 🎉

@davepagurek

- Changed frameCount from int1 to float1 for JS compatibility - Removed mouseButton (object type in p5 2.x) - Added unit tests for all 14 global properties Addresses feedback from @davepagurek in processing#8211

avinxshKD and others added 2 commits October 28, 2025 00:37

feat(webgl): add global property support for p5.strands

0251a23

Merge branch 'dev-2.0' into strands-support-globals

1641398

davepagurek reviewed Nov 12, 2025

View reviewed changes

fix: change frameCount to float1, remove mouseButton, add unit tests

12a3f50

- Changed frameCount from int1 to float1 for JS compatibility - Removed mouseButton (object type in p5 2.x) - Added unit tests for all 14 global properties Addresses feedback from @davepagurek in processing#8211

Merge branch 'dev-2.0' into strands-support-globals

aa96ea9

perminder-17 self-requested a review January 23, 2026 06:45

perminder-17 added 5 commits January 25, 2026 23:07

Add builtin global accessors and enhance hooks

9a185ad

Merge branch 'dev-2.0' into strands-support-globals

ccd855c

Delete test/unit/webgl/strands.js

c393374

Add mouse and window properties to BUILTIN_GLOBAL_SPECS

1721497

Implement tests for global variables in shader hooks

df6cff1

perminder-17 reviewed Jan 25, 2026

View reviewed changes

perminder-17 added 2 commits January 26, 2026 00:06

Fixing tests

30fcf4d

Removed redundant assertions for mxInHook and wInHook.

some minor fixes

6e5bd17

davepagurek reviewed Jan 26, 2026

View reviewed changes

perminder-17 and others added 2 commits January 27, 2026 23:15

Implement visual test for global property width and height

3db94cd

Add visual test for getFinalColor using width/height

forgot to run tests locally

2fdd571

davepagurek reviewed Jan 27, 2026

View reviewed changes

perminder-17 added 2 commits February 1, 2026 03:15

strands specific fix

c5f4665

Merge branch 'dev-2.0' into strands-support-globals

edecbc1

davepagurek merged commit ee063c6 into processing:dev-2.0 Feb 1, 2026
2 checks passed

allcontributors bot mentioned this pull request Feb 1, 2026

docs: add avinxshKD as a contributor for code #8483

Merged

ksen0 added this to p5.js 2.x 🌱🌳 Feb 11, 2026

github-project-automation bot moved this to Completed in p5.js 2.x 🌱🌳 Feb 11, 2026

ksen0 added this to the 2.3 milestone Feb 11, 2026

Uh oh!

Conversation

avinxshKD commented Oct 27, 2025

What was changed:

PR Checklist

Uh oh!

avinxshKD commented Nov 10, 2025

Uh oh!

davepagurek left a comment

Choose a reason for hiding this comment

Uh oh!

davepagurek Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

davepagurek Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

avinxshKD commented Nov 24, 2025

Uh oh!

davepagurek commented Jan 4, 2026

Uh oh!

perminder-17 Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

davepagurek Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

perminder-17 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

davepagurek left a comment

Choose a reason for hiding this comment

Uh oh!

perminder-17 commented Jan 26, 2026

Uh oh!

davepagurek Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

davepagurek commented Jan 27, 2026

Uh oh!

avinxshKD commented Jan 28, 2026

Uh oh!

perminder-17 commented Jan 31, 2026

Uh oh!

Uh oh!

davepagurek commented Feb 1, 2026

Uh oh!

allcontributors bot commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments