Replace hardcoded aria-labels with i18n#3894
Open
avinxshKD wants to merge 1 commit intoprocessing:developfrom
Open
Replace hardcoded aria-labels with i18n#3894avinxshKD wants to merge 1 commit intoprocessing:developfrom
avinxshKD wants to merge 1 commit intoprocessing:developfrom
Conversation
Author
|
@raclim pls take a look into this, let me know if any adjustments needed thanks |
Author
|
@yugalkaushik thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3849
Replaced hardcoded English aria-labels with i18n translations to support localization.
Changes:
aria-label="Previous Page"-t('Pagination.PreviousPageARIA')aria-label="Select p5.js version"-t('Toolbar.SelectVersionARIA')aria-label="Close Alert"-t('Toast.CloseAlertARIA')aria-label="Copy"-t('TextArea.CopyARIA')ButtonRemoveARIA/ButtonAddToCollectionARIAAll new keys added to
translations/locales/en-US/translations.jsonfollowing the existing*ARIAnaming conventionChecklist:
npm run lint)npm run test)npm run typecheck)developbranch