Skip to content

Replace hardcoded aria-labels with i18n#3894

Open
avinxshKD wants to merge 1 commit intoprocessing:developfrom
avinxshKD:fix/i18n-hardcoded-aria-labels
Open

Replace hardcoded aria-labels with i18n#3894
avinxshKD wants to merge 1 commit intoprocessing:developfrom
avinxshKD:fix/i18n-hardcoded-aria-labels

Conversation

@avinxshKD
Copy link

Fixes #3849

Replaced hardcoded English aria-labels with i18n translations to support localization.

Changes:

  • Pagination: aria-label="Previous Page" - t('Pagination.PreviousPageARIA')
  • VersionPicker: aria-label="Select p5.js version" - t('Toolbar.SelectVersionARIA')
  • Toast: aria-label="Close Alert" - t('Toast.CloseAlertARIA')
  • TextArea: aria-label="Copy" - t('TextArea.CopyARIA')
  • QuickAddList/Icons: Fixed incorrect "Descending" labels, now uses ButtonRemoveARIA/ButtonAddToCollectionARIA

All new keys added to translations/locales/en-US/translations.json following the existing *ARIA naming convention

Checklist:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch
  • is descriptively named and links to an issue number
  • meets accessibility guidelines

@avinxshKD
Copy link
Author

@raclim pls take a look into this, let me know if any adjustments needed thanks

Copy link
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avinxshKD
Copy link
Author

@yugalkaushik thanks for the review
can you pls take a look into this too? #3861 i wanna know if any adjustments needed or its ready to merge, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some aria-labels are hardcoded in English instead of using i18n

2 participants