Support single-file leagues in MatchHistory - #970
Open
shawnhdx0710 wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Football-data.co.uk publishes some leagues in a single file. The file holds the full match history for all seasons. The Swiss Super League is an example. These files live at
/new/{league}.csv. They use a different subset of column names than the per-season files.MatchHistorycurrently reads only the per-season files at/mmz4281/{season}/{league}.csv. For a single-file league, this URL does not exist. The request returns a 404. This change fixes issue #589.What changed
single_fileflag to the league config.read_gamesdownloads/new/{league}.csvonce. It does not loop over the seasons.How to use
Add a custom league to
league_dict.jsonwith thesingle_fileflag:{ "SUI-Super League": { "MatchHistory": "SWZ", "single_file": true, "season_start": "Jul", "season_end": "May" } }Tests
Added
test_read_games_single_file. It uses a synthetic fixture file. It does not hit the network.Documentation
Updated
docs/datasources/MatchHistory.ipynb.Fixes #589