fix(docs): use local TypeScript compiler in package manager tabs#8086
Conversation
Signed-off-by: futurehua <futurehua@outlook.com>
|
@futurehua is attempting to deploy a commit to the Prisma Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
ChangesTypeScript command conversion
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@nurul3101 @ankur-arch Hi, Could you please review this PR at your convenience? Thank you very much. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you @futurehua! |
Summary
npx tscintopnpm dlx tscoryarn dlx tsc.pnpm tscandyarn tsc.dlxconversions.Fixes #8064.
Why
The documentation installs
typescriptbefore runningtsc, butnpm-to-yarncurrently convertsnpx tsc --initto:pnpm dlx tsc --inityarn dlx tsc --initBoth
dlxcommands fetch the package namedtscfrom the registry instead of using the binary from the locally installedtypescriptpackage. That registry package is an unrelated deprecated placeholder, so the generated quickstart commands fail.The fix is applied at the shared command-conversion boundary so every npm code block containing
npx tscproduces the correct pnpm and Yarn commands.Validation
npx tsc --initpnpm tsc --inityarn tsc --initbunx tsc --initpnpm exec oxfmt --check apps/docs/source.config.tspnpm exec oxlint apps/docs/source.config.tspnpm --filter docs run types:checkSummary by CodeRabbit