perf: memoize icon, label, and badge rendering in Button component to prevent unnecessary re-renders#8527
Closed
mustafajw07 wants to merge 1 commit intoprimefaces:masterfrom
Closed
Conversation
… prevent unnecessary re-renders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8526
Defect Fixes
This PR improves the performance of the Button component by memoizing the results of createIcon, createLabel, and createBadge.
Currently, these helper functions are executed on every render, even when their dependent props do not change. This may lead to unnecessary recalculations in scenarios where the Button component re-renders frequently.
💡 Changes
Wrapped createIcon, createLabel, and createBadge with React.useMemo
Added appropriate dependency arrays based on relevant props