fix: keep parens when calling the result of an assignment

src/needs-parens.mjs

@@ -179,7 +179,10 @@ function needsParens(path, options) {
       } else if (parent.kind === "silent") {
         return false;
       } else if (parent.kind === "call") {
-        return false;
+        // `($fn = function () {})()` needs the parentheses: without them
+        // the call binds to the closure instead of the assignment result.
+        // https://github.com/prettier/plugin-php/issues/2409
+        return key === "what";
       }
 
       return true;

tests/assign-call/__snapshots__/jsfmt.spec.mjs.snap

@@ -0,0 +1,35 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`assign-call.php 1`] = `
+====================================options=====================================
+parsers: ["php"]
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+<?php
+($fib = function () { return 42; })(10);
+
+$result = ($fib = function ($n) use (&$fib) {
+    return $n <= 1 ? $n : $fib($n - 1) + $fib($n - 2);
+})(10);
+
+($fn = fn () => 42)();
+
+call($a = $b);
+
+=====================================output=====================================
+<?php
+($fib = function () {
+    return 42;
+})(10);
+
+$result = ($fib = function ($n) use (&$fib) {
+    return $n <= 1 ? $n : $fib($n - 1) + $fib($n - 2);
+})(10);
+
+($fn = fn() => 42)();
+
+call($a = $b);
+
+================================================================================
+`;

tests/assign-call/assign-call.php

@@ -0,0 +1,10 @@
+<?php
+($fib = function () { return 42; })(10);
+
+$result = ($fib = function ($n) use (&$fib) {
+    return $n <= 1 ? $n : $fib($n - 1) + $fib($n - 2);
+})(10);
+
+($fn = fn () => 42)();
+
+call($a = $b);

tests/assign-call/jsfmt.spec.mjs

@@ -0,0 +1 @@
+run_spec(import.meta, ["php"]);