Repository navigation
Fix force-generate for framework manifests - #891
Merged
tdstein merged 1 commit intoOct 28, 2026
Merged
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Collaborator
Author
|
@amol- it looks like you originally introduced the behavior that I'm undoing in this change. Mind taking a look to confirm this change is appropriate? |
amol-
approved these changes
Oct 27, 2026
Collaborator
There was a problem hiding this comment.
I think this looks good manifest_writer is already resolving the requirements file option, so _write_framework_manifest has no need to resolve it again.
To be honest, given that _write_framework_manifest is only ever used by manifest_writer I'm not even sure the reason why it should exist as a separate entity. Having them separated increases the risk of this type of errors by making harder to keep track of the interactions between the two.
tdstein
deleted the
symphony/posit-dev_rsconnect-python_888-24f395341e675783
branch
October 28, 2026 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--force-generateuses pip freeze.Validation
Closes #888