Skip to content

Fix force-generate for framework manifests - #891

Merged
tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_888-24f395341e675783
Oct 28, 2026
Merged

tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_888-24f395341e675783

Conversation

@tdstein

@tdstein tdstein commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve the resolved requirements source when writing framework manifests so --force-generate uses pip freeze.
  • Add CLI regression coverage for generated and explicitly supplied requirements files.

Validation

  • Focused manifest and environment tests (69 tests).
  • Ruff lint and formatting checks; committed diff check.

Closes #888

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-28 13:25 UTC

@github-actions

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11019 9681 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/main.py 85% 🟢
TOTAL 85% 🟢

updated for commit: 577cb37 by action🐍

@tdstein
tdstein requested a review from amol- October 27, 2026 21:24
@tdstein

tdstein commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

@amol- it looks like you originally introduced the behavior that I'm undoing in this change. Mind taking a look to confirm this change is appropriate?

@amol- amol- left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good manifest_writer is already resolving the requirements file option, so _write_framework_manifest has no need to resolve it again.

To be honest, given that _write_framework_manifest is only ever used by manifest_writer I'm not even sure the reason why it should exist as a separate entity. Having them separated increases the risk of this type of errors by making harder to keep track of the interactions between the two.

@tdstein
tdstein merged commit 0287aca into main Oct 28, 2026
27 checks passed
@tdstein
tdstein deleted the symphony/posit-dev_rsconnect-python_888-24f395341e675783 branch October 28, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

write-manifest <framework> ignores --force-generate

2 participants