Add property-based tests for nullable-field JSON converters#95
Merged
SeanTAllen merged 1 commit intomainfrom Mar 3, 2026
Merged
Add property-based tests for nullable-field JSON converters#95SeanTAllen merged 1 commit intomainfrom
SeanTAllen merged 1 commit intomainfrom
Conversation
Item 2 from Discussion #93: test converters that exercise `string_or_none` and `try/else None` paths. 9 new test classes covering LabelJsonConverter (7 fields including nullable description), IssuePullRequestJsonConverter (5 fields including nullable merged_at), AssetJsonConverter (13 fields including nullable label and nested UserJsonConverter), and GistFileJsonConverter (5 required fields, 1 nullable, 3 optional). Each converter gets preserves-values (with Bool generator randomly nullifying nullable fields) and missing-required-field tests. GistFile gets an additional absent-optional-fields test verifying that omitted content/encoding/truncated keys produce None. A _TestUserJson helper primitive builds valid User JSON objects for Asset tests that need a nested User. Design: #93
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 2 from Discussion #93: test converters that exercise
string_or_noneandtry/else Nonepaths.9 new property-based test classes covering 4 converters:
descriptionmerged_atlabeland nestedUserJsonConverterlanguage), 3 optional (content,encoding,truncated)Each converter gets:
Boolgenerator randomly nullifies nullable fields; asserts required fields match and nullable fields are correctlyStringorNoneUSizegenerator selects which required field to omit; asserts converter errorsGistFile gets an additional absent-optional-fields test verifying that omitted
content/encoding/truncatedkeys produceNone.A
_TestUserJsonhelper primitive builds valid User JSON objects for Asset tests that need a nested User.Design: #93