Skip to content

Visor: persistent drawer action bar above the strip - #188

Merged
lannbot merged 1 commit into
mainfrom
visor/drawer-action-bar
Sep 10, 2026
Merged

Visor: persistent drawer action bar above the strip#188
lannbot merged 1 commit into
mainfrom
visor/drawer-action-bar

Conversation

@lannbot

@lannbot lannbot commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a non-scrolling action bar directly above the strip, inside the existing drawer height budget.
  • Show Close on clean dismissible sheets; replace it with Save and Revert when settings or app-label drafts are modified.
  • Keep Save/Revert in the current sheet. Preserve existing unsaved-navigation confirmation, and omit actions on the pinned app list and unlock screen as requested.
  • Remove the pane-top dismissal and inline settings Save/Revert controls they replace.
  • Guard in-flight saves against duplicate submission/navigation, preserve newer edits, and keep keyboard focus on a useful control without stealing it from ongoing typing.

Verification

  • Astra review complete; real Chromium desktop/mobile clean and dirty screenshots inspected.
  • just check passed.
  • just test passed, including 36 Deno tests.
  • just e2e passed: 29 scenarios, including contrast/touch coverage.
  • Behavioral coverage checks persistence, Revert, app-label saves, pinned screens, keyboard focus, in-flight edits/navigation, confirmation, and the bar remaining attached after pane scrolling and mobile resize.

Automerge will be armed.

@lannbot
lannbot enabled auto-merge September 10, 2026 17:24
@lannbot
lannbot merged commit c044b4a into main Sep 10, 2026
2 checks passed
@lannbot
lannbot deleted the visor/drawer-action-bar branch September 10, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants