embedder: give host resource registrations independent lifetimes - #332
Merged
Conversation
lannbot
enabled auto-merge
September 11, 2026 01:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #330.
breaking/protocol); the lockstep runtime packages stay at 0.6.8.Semantics
Resource identity is distinct from backing-data identity. The pinned Component Model creates fresh resource handles and independently calls the destructor for each owned drop; it does not merge lifetimes by representation equality. Existing resource-handle lowering remains an ownership transfer. Wasmtime corroboration and pinned source citations are in #330.
Host providers that return the same object repeatedly now receive a disposal invocation per independent registration. Plain-object host borrows no longer delay disposal of unrelated own registrations backed by that object. Managing shared backing data is the provider's responsibility.
Verification
just gatesrecipes completed across resumed invocations: the initial command hit a 120s tool timeout insched-seeds; remaining recipes resumed with a larger timeout. Installed missing Playwright browsers withjust browsers-install, then reranjust browserssuccessfully.git diff --check,just fmt-check,just lint,just version-guard-localpassed. Existing convention goldens unchanged.Automerge will be armed after creation, with merge after required core checks.