Fix O(m^2) assembly in HypreSolver::factorize#111
Open
Chenyang-Joe wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 80.76% 80.73% -0.03%
==========================================
Files 51 51
Lines 2121 2118 -3
Branches 281 280 -1
==========================================
- Hits 1713 1710 -3
Misses 408 408
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
iiiian
approved these changes
Jul 8, 2026
teseoch
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HypreSolver::factorizebuilds the HYPRE matrix with a nested loop: for each nonzeroin a column it rebuilds and re-sets the entire column, so every column is handed to
HYPRE_IJMatrixSetValuesnnz(col)times. Assembly is therefore O(m^2) in the numberof nonzeros and dominates solve setup on large matrices.
Fix
Build each column's index/value arrays once and set it in a single
HYPRE_IJMatrixSetValuescall -> O(nnz) total. The assembled matrix (and the
solution) is unchanged.
Testing
ctestsuite passes 27/27, includinghypreandhypre_initial_guess.@maxpaik16 PTAL, thanks!