fix(ts-sdk): exclude markets missing resolutionDate in filterMarkets - #1990
Open
adamantmm wants to merge 1 commit into
Open
fix(ts-sdk): exclude markets missing resolutionDate in filterMarkets#1990adamantmm wants to merge 1 commit into
adamantmm wants to merge 1 commit into
Conversation
Align the TypeScript SDK with core and the Python SDK: when filtering by resolutionDate, markets without a date are excluded instead of silently passing through. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1969.
When
filterMarketsis called with aresolutionDatecriterion, markets that have noresolutionDateset were incorrectly included in the TypeScript SDK. Core and the Python SDK already exclude them (if (!resDate) return false/if not val: continue).This change mirrors that behavior in
sdks/typescript/pmxt/client.ts.How to test
filterMarkets(markets, { resolutionDate: { before: someDate } })with a mix of markets that have and lackresolutionDate.resolutionDateshould be absent from the result (same as core / Python).Checklist
BaseExchange.filterMarketsresolutionDate handling