Fix Flask-WTF/Quart-WTF CSRF exemptions broken by backend refactor#3885
Open
T4rk1n wants to merge 1 commit into
Open
Fix Flask-WTF/Quart-WTF CSRF exemptions broken by backend refactor#3885T4rk1n wants to merge 1 commit into
T4rk1n wants to merge 1 commit into
Conversation
The backend refactor moved callback dispatching from Dash.dispatch into
nested closures in the backend modules, changing the view function's
fully-qualified name from dash.dash.dispatch to
dash.backends._flask._dispatch. Flask-WTF's CSRFProtect exempts views by
that name, so csrf._exempt_views.add("dash.dash.dispatch") silently
stopped working, raising "The CSRF token is missing." on every callback.
Restore the dispatch view's identity to dash.dash.dispatch in the Flask
and Quart backends so existing exemptions keep working.
Fixes #3827
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend refactor moved callback dispatching from
Dash.dispatchinto nested closures in the backend modules, changing the view function's fully-qualified name from dash.dash.dispatch todash.backends._flask._dispatch. Flask-WTF's CSRFProtect exempts views by that name, socsrf._exempt_views.add("dash.dash.dispatch")silently stopped working, raising "The CSRF token is missing." on every callback.Restore the dispatch view's identity to dash.dash.dispatch in the Flask and Quart backends so existing exemptions keep working.
Fixes #3827