Stop the browser on a redirect when followRedirects(false) - #54
Draft
kbond wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: this branch is based on #53, so the diff includes it. I will rebase once that lands.
followRedirects(false)currently does nothing. The flag is inherited fromAbstractBrowserandisFollowingRedirects()reports it correctly, but the route handler follows every 3xx regardless.This makes it stop instead: the 3xx is fulfilled as a
200with noLocationand an empty body, so the browser parks on the url that redirected whilegetLastSymfonyResponse()keeps the real status andLocationfor the caller to inspect. The body has to be dropped because aRedirectResponsecarries a<meta http-equiv="refresh">that navigates whatever the status says.followRedirect()then steps a stopped redirect one hop at a time.fetchredirects keep their client-side replay:followRedirects()is about where the test client navigates, not what application JS askedfetch()to do.This is what
zenstruck/browserneeds forinterceptRedirects(),followRedirect(),assertRedirected(),assertRedirectedTo()andclickAndIntercept(), whose existingKernelBrowserimplementations already call exactlyfollowRedirects(false).